Add SwiftLint #261
Closed
Add SwiftLint #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokagio
force-pushed
the
add-swiftlint
branch
3 times, most recently
from
513029c to
5d67ad6
Compare
Relaxed the requirement because for the usage we do of CocoaPods in this repo, any 1.x version will do.
I find this is a simpler way to add SwiftLint because by using a tool that is already a required part of the setup, it doesn't need extra scripts or commands that devs may forget to run.
mokagio
force-pushed
the
add-swiftlint
branch
from
5d67ad6 to
07e66ec
Compare
|
Closing as stale. Funny enough, I worked on SwiftLint for HACK Week Q2 2022 and the stuff done here was a great place to start. I hope to port the setup (wordpress-mobile/WordPressKit-iOS#517, wordpress-mobile/WordPressKit-iOS#519, wordpress-mobile/WordPressKit-iOS#518) here "soon". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My hack week project for Q2 of 2020 is to add linters everywhere I can.
This PR adds SwiftLint to this pod, using at
.swiftlint.ymlconfig from the WordPress-iOS app.There is an open PR on the SwiftLint repo to add support for a remote config file, which is what I'll try to do next.