Fix display of certain topics in Discover recommendations

wordpress-mobile · Jan 10, 2025 · 7599361 · 7599361
1 parent daaa5ad
commit 7599361
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/WordPress/Classes/Models/ReaderTagTopic.swift b/WordPress/Classes/Models/ReaderTagTopic.swift
@@ -52,6 +52,10 @@ import Foundation
         return topic
     }
 
+    var formattedTitle: String {
+        title.split(separator: "-").map(\.capitalized).joined(separator: " ")
+    }
+
     /// Convenience method to update the tag's `following` state and also updates `showInMenu`.
     @objc func toggleFollowing(_ isFollowing: Bool) {
         following = isFollowing

diff --git a/WordPress/Classes/ViewRelated/Reader/Headers/ReaderDiscoverHeaderView.swift b/WordPress/Classes/ViewRelated/Reader/Headers/ReaderDiscoverHeaderView.swift
@@ -215,7 +215,7 @@ enum ReaderDiscoverChannel: Hashable {
         case .dailyPrompts:
             NSLocalizedString("reader.discover.channel.dailyPrompts", value: "Daily Prompts", comment: "Header view channel (filter)")
         case .tag(let tag):
-            tag.title.localizedCapitalized
+            tag.formattedTitle
         }
     }
 

diff --git a/WordPress/Classes/ViewRelated/Reader/Headers/ReaderTagStreamHeader.swift b/WordPress/Classes/ViewRelated/Reader/Headers/ReaderTagStreamHeader.swift
@@ -41,7 +41,11 @@ final class ReaderTagStreamHeader: ReaderBaseHeaderView, ReaderStreamHeader {
     // MARK: - Configuration
 
     public func configureHeader(_ topic: ReaderAbstractTopic) {
-        titleLabel.text = topic.title.split(separator: "-").map { $0.capitalized }.joined(separator: " ")
+        if let tag = topic as? ReaderTagTopic {
+            titleLabel.text = tag.formattedTitle
+        } else {
+            titleLabel.text = topic.title
+        }
         followButton.isSelected = topic.following
         WPStyleGuide.applyTagsReaderButtonStyle(followButton)
     }