Remove more uses of flipInsetsForRightToLeftLayoutDirection

wordpress-mobile · Nov 14, 2024 · 9772eb1 · 9772eb1
1 parent ae0dce8
commit 9772eb1
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 26 deletions.
diff --git a/WordPress/Classes/Extensions/UIEdgeInsets.swift b/WordPress/Classes/Extensions/UIEdgeInsets.swift
@@ -5,33 +5,10 @@ extension UIEdgeInsets {
         guard UIApplication.shared.userInterfaceLayoutDirection == .rightToLeft else {
             return self
         }
-
         return flippedForRightToLeftLayoutDirection()
     }
 
     func flippedForRightToLeftLayoutDirection() -> UIEdgeInsets {
         return UIEdgeInsets(top: top, left: right, bottom: bottom, right: left)
     }
 }
-
-extension UIButton {
-
-    @objc func flipInsetsForRightToLeftLayoutDirection() {
-        guard userInterfaceLayoutDirection() == .rightToLeft else {
-            return
-        }
-        contentEdgeInsets = contentEdgeInsets.flippedForRightToLeftLayoutDirection()
-        imageEdgeInsets = imageEdgeInsets.flippedForRightToLeftLayoutDirection()
-        titleEdgeInsets = titleEdgeInsets.flippedForRightToLeftLayoutDirection()
-    }
-}
-
-// Hack: Since UIEdgeInsets is a struct in ObjC, you can't have methods on it.
-// You can't also export top level functions from Swift.
-// 🙄
-@objc(InsetsHelper)
-class _InsetsHelper: NSObject {
-    @objc static func flipForRightToLeftLayoutDirection(_ insets: UIEdgeInsets) -> UIEdgeInsets {
-        return insets.flippedForRightToLeftLayoutDirection()
-    }
-}
diff --git a/WordPress/Classes/ViewRelated/Comments/Views/Detail/CommentContentTableViewCell.swift b/WordPress/Classes/ViewRelated/Comments/Views/Detail/CommentContentTableViewCell.swift
@@ -385,7 +385,6 @@ private extension CommentContentTableViewCell {
         replyButton?.setTitleColor(Style.reactionButtonTextColor, for: .normal)
         replyButton?.setImage(Style.replyIconImage, for: .normal)
         replyButton?.addTarget(self, action: #selector(replyButtonTapped), for: .touchUpInside)
-        replyButton?.flipInsetsForRightToLeftLayoutDirection()
         replyButton?.adjustsImageSizeForAccessibilityContentSizeCategory = true
         adjustImageAndTitleEdgeInsets(for: replyButton)
         replyButton?.sizeToFit()
@@ -397,7 +396,6 @@ private extension CommentContentTableViewCell {
         likeButton?.titleLabel?.adjustsFontForContentSizeCategory = true
         likeButton?.setTitleColor(Style.reactionButtonTextColor, for: .normal)
         likeButton?.addTarget(self, action: #selector(likeButtonTapped), for: .touchUpInside)
-        likeButton?.flipInsetsForRightToLeftLayoutDirection()
         likeButton?.adjustsImageSizeForAccessibilityContentSizeCategory = true
         adjustImageAndTitleEdgeInsets(for: likeButton)
         updateLikeButton(liked: false, numberOfLikes: 0)

diff --git a/WordPress/Classes/ViewRelated/Jetpack/Branding/Button/JetpackButton.swift b/WordPress/Classes/ViewRelated/Jetpack/Branding/Button/JetpackButton.swift
@@ -78,7 +78,6 @@ class JetpackButton: CircularImageButton {
         imageEdgeInsets = Appearance.iconInsets
         contentEdgeInsets = Appearance.contentInsets
         imageView?.contentMode = .scaleAspectFit
-        flipInsetsForRightToLeftLayoutDirection()
         setImageBackgroundColor(imageBackgroundColor)
     }