Skip to content

Commit

Permalink
Remove ellipsis from the share button (#23975)
Browse files Browse the repository at this point in the history
* Remove ellipsis from the share button

* Fix typo on MediaUtilityTask
  • Loading branch information
kean authored Jan 14, 2025
1 parent 1e120e3 commit d820f57
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ class BlogDetailHeaderView: UIView {

private func makeSiteLinkMenu() -> UIMenu {
UIMenu(children: [
UIAction(title: SharedStrings.Button.share + "", image: UIImage(systemName: "square.and.arrow.up"), handler: { [weak self] _ in
UIAction(title: SharedStrings.Button.share, image: UIImage(systemName: "square.and.arrow.up"), handler: { [weak self] _ in
self?.delegate?.buttonShareSiteTapped()
}),
UIAction(title: Strings.visitSite, image: UIImage(systemName: "safari"), handler: { [weak self] _ in
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ private enum MenuItem {
var title: String {
switch self {
case .visitSite: return Strings.visitSite
case .shareSite: return SharedStrings.Button.share + ""
case .shareSite: return SharedStrings.Button.share
case .siteTitle: return Strings.siteTitle
case .personalizeHome: return Strings.personalizeHome
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ class EditorMediaUtility {
callbackQueue.async {
failure(error)
}
return MeediaUtilityTask { /* do nothing */ }
return MediaUtilityTask { /* do nothing */ }
case let .success((imageURL, host)):
let task = Task { @MainActor in
do {
Expand All @@ -98,7 +98,7 @@ class EditorMediaUtility {

}
}
return MeediaUtilityTask { task.cancel() }
return MediaUtilityTask { task.cancel() }
}
}

Expand Down Expand Up @@ -202,7 +202,7 @@ class EditorMediaUtility {
}
}

private struct MeediaUtilityTask: ImageDownloaderTask {
private struct MediaUtilityTask: ImageDownloaderTask {
let closure: @Sendable () -> Void

func cancel() {
Expand Down

0 comments on commit d820f57

Please sign in to comment.