Fix Jetpack app review URL

[guarani]

Fixes #19300

Ratings submitted for the Jetpack app were submitted to the WordPress app's store listing. This happened because the app used the incorrect URL to open the App Store app review screen. While the app correctly defined the URL for the Jetpack app, it was then overwritten at runtime by a URL fetched from an endpoint. This endpoint was only returning a URL for the WordPress app, so it overwrote the Jetpack app's URL with the WordPress app's one.

This PR mitigates the problem on the Jetpack app by skipping the endpoint request for the Jetpack app only. This doesn't change behavior on the WordPress app. The impact of this change is that we can no longer remotely disable in-app requests for reviews. However, I don't recall this ever being used. The priority here is to restore the Rate Us functionality for the Jetpack app so that follow-up work can look for a more permanent fix.

To test

0. Run the Jetpack app on a physical device
1. Go to the "My Site" tab
2. Tap profile pic
3. Tap "About Jetpack for iOS"
4. Tap "Rate Us"
5. When the modal screen is presented to rate the app, the Jetpack app listing should be shown behind the modal
6. Submit a review
7. Verify that the review was submitted for the Jetpack app:
   a. Open the App Store app
   b. Tap your profile picture
   c. Tap your name
   d. Tap "Ratings and Reviews"
   e. Ensure that the rating was submitted for the Jetpack app
8. Repeat Steps 0-7 for the WordPress app, but this time ensure the review is submitted for the WordPress app

Regression Notes

1. Potential unintended areas of impact

This PR intentionally disables the ability to remotely turn off in-app review prompts for the Jetpack app. My current understanding is that this remote ability was not used often, so disabling it won't cause a significant negative impact.

2. What I did to test those areas of impact (or what existing automated tests I relied on)

Tested the review submission process using the above testing steps.

4. What automated tests I added (or what prevented me from doing so)

None, automated testing isn't practical for the review submission UI.

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

	Warnings
⚠️	PR is not assigned to a milestone.

Generated by 🚫 dangerJS

[twstokes]

👋 @guarani - I tested:

• WordPress app -> Me -> About WordPress for iOS -> Rate Us
• Jetpack app -> Me -> About Jetpack for iOS -> Rate Us

And both went to their respective App Store pages to add a review, so these changes look good to me! I did have one question about the ScreenObject dependency version bump. Thanks!

[wpmobilebot]

You can test the changes in Jetpack from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr19299-f1b0f42 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[wpmobilebot]

You can test the changes in WordPress from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr19299-f1b0f42 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[twstokes]

LGTM @guarani. 🚀

[twstokes]

I will add one more thing about my review process - I stopped at step 5 in your testing steps "When the modal screen is presented to rate the app, the [app name] listing should be shown behind the modal". I felt this was enough to confirm it went to the right URL, but let me know if you disagree.

[guarani]

I felt this was enough to confirm it went to the right URL, but let me know if you disagree.

I agree this is a good enough check. Thanks for the review @twstokes!

[guarani]

👋 @mokagio, we think this deserves a betafix (in short, JP app reviews from the "Rate Us" functionality were going to the WP app instead).

I'm merging this into release/20.7 now. Please let me know if there's anything else I should do here (nothing comes to mind, but I haven't betafixed for a while).

[guarani]

PS I didn't add release notes because I the release is already cut and I figured it's too late to get them translated. I could be wrong about it being too late though since we're still in the beta's first week.

That said, we estimated that the JP app was only getting at most 1 review per month, so I also don't think this bug fix is impactful enough for general users to warrant adding release notes. Please let me know if you think otherwise.

[mokagio]

@guarani this has been bundled as part of 20.7 beta 2 (20.7.0.2).

Thanks for your work 🙌

PS I didn't add release notes because I the release is already cut and I figured it's too late to get them translated. I could be wrong about it being too late though since we're still in the beta's first week.

Good call. The main issue with adding release notes after the first couple of days of the code freeze is that the editorialized version has already been made, so any update would need to go through editorialization and be resubmitted for translation (if landing after the second Monday of the sprint).

[guarani]

Hey @mokagio, thanks for clarifying that it isn't just translation, but also editorialization, that wouldn't have had time to be completed had I added release notes for this.