Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate gutenberg-mobile release v1.109.2 #22149

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Dec 5, 2023

Description

This PR incorporates the 1.109.2 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#6442

Release Submission Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the Gutenberg Editing and display of Gutenberg blocks. label Dec 5, 2023
@fluiddot fluiddot added this to the 23.8 ❄️ milestone Dec 5, 2023
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 5, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22149-1a77b1f
Version23.8
Bundle IDorg.wordpress.alpha
Commit1a77b1f
App Center BuildWPiOS - One-Offs #8046
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 5, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22149-1a77b1f
Version23.8
Bundle IDcom.jetpack.alpha
Commit1a77b1f
App Center Buildjetpack-installable-builds #7067
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@SiobhyB SiobhyB self-requested a review December 5, 2023 13:34
@fluiddot
Copy link
Contributor Author

fluiddot commented Dec 5, 2023

⚠️ UI test testCreateScheduledPost failed on both iPhone and iPad. The Gutenberg changes aren't related to the scheduling feature, so this might be a one-off failure. In any case, I'll test manually to double-check the feature works as expected.

@fluiddot
Copy link
Contributor Author

fluiddot commented Dec 5, 2023

⚠️ UI test testCreateScheduledPost failed on both iPhone and iPad. The Gutenberg changes aren't related to the scheduling feature, so this might be a one-off failure. In any case, I'll test manually to double-check the feature works as expected.

This issue will be solved by cherry-picking #22135. We confirmed that it's unrelated to the Gutenberg changes, so it shouldn't be a blocker for the PR.

Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that the editor loads as expected for me, and the writing tests passed. As discussed also, the fix from #22135 will address the failing test, which is an issue specific to tests rather than functionality.

Approved :shipit:

fluiddot and others added 2 commits December 5, 2023 17:02
@fluiddot fluiddot requested a review from a team as a code owner December 5, 2023 16:10
@fluiddot fluiddot removed the request for review from a team December 5, 2023 16:10
@wpmobilebot
Copy link
Contributor

1 Warning
⚠️ This PR is assigned to the milestone 23.8 ❄️. The due date for this milestone has already passed.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@fluiddot fluiddot merged commit 142f7c4 into release/23.8 Dec 5, 2023
@fluiddot fluiddot deleted the gutenberg/integrate_release_1.109.2 branch December 5, 2023 18:00
@mokagio mokagio mentioned this pull request Dec 6, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants