-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Gutenberg block processors performance to avoid long delay when saving a post #22845
Closed
fluiddot
wants to merge
6
commits into
add/gutenberg-content-parsing
from
update/improve-gutenberg-block-procesors
Closed
Improve Gutenberg block processors performance to avoid long delay when saving a post #22845
fluiddot
wants to merge
6
commits into
add/gutenberg-content-parsing
from
update/improve-gutenberg-block-procesors
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr22845-5547592 | |
Version | 24.5 | |
Bundle ID | org.wordpress.alpha | |
Commit | 5547592 | |
App Center Build | WPiOS - One-Offs #9232 |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr22845-5547592 | |
Version | 24.5 | |
Bundle ID | com.jetpack.alpha | |
Commit | 5547592 | |
App Center Build | jetpack-installable-builds #8277 |
7f9e423
to
5547592
Compare
I'm considering splitting this PR into smaller PRs, one for each block processor. |
Closing in favor of new PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#6696.
Note
Uses the changes from #22886.
[Add Benchmark]
To test
Follow the testing instructions to cover the functionality related to the processors for each block:
Gallery block:
Image Block:
File Block:
Cover Block:
Regression Notes
Potential unintended areas of impact
The block processors are only used when saving a post. No other area should be impacted.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manually tested saving a post with different blocks. Additionally, each processor has its own unit test that has been verified.
What automated tests I added (or what prevented me from doing so)
Some unit tests have been added to cover the content parsing.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: