Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline Mode: Update post.status handling in post/page settings #23071

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented Apr 23, 2024

Changes

Pending Review

"Pending review" is now a toggle (like in Gutenberg):

Screenshot 2024-04-23 at 6 13 05 PM

Status

In the previous implementation, there was an overlap between "Visibility" and "Status":

Screenshot 2024-04-23 at 5 05 39 PM

The new implementation matches Gutenberg:

Screenshot 2024-04-23 at 6 10 39 PM

With these settings you can change the visibility of the posts using "Visibility" and move the post to draft or trash it using dedicated context menu actions, so there is now complete parity with Gutenberg.

Post Settings

  • Fix an issue where saving "Post Settings" changes was a sync operation for .pending posts (but async for .draft)

Note

  • The changes are under the "Sync Publishing" feature flag

To test:

Test 1.1

  • Create and save a draft post
  • ✅ Use the new "Pending Review" toggle from Post Settings to move the post in and out of review

Test 1.2

  • Open "Post Settings" for a pending post
  • Change some of the settings
  • Tap "Save"
  • ✅ Verify that the save is performed asynchronously and can be performed offline

Test 1.3

  • Open "Post Settings" for a published or a scheduled post
  • ✅ Verify that the "Status" field is no longer present

Regression Notes

  1. Potential unintended areas of impact: Post List & Settings
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the 24.8 milestone Apr 23, 2024
@kean kean requested a review from momo-ozawa April 23, 2024 22:17
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 23, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23071-b59394d
Version24.7
Bundle IDcom.jetpack.alpha
Commitb59394d
App Center Buildjetpack-installable-builds #8682
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 23, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23071-b59394d
Version24.7
Bundle IDorg.wordpress.alpha
Commitb59394d
App Center BuildWPiOS - One-Offs #9637
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean force-pushed the task/revert-pending-change branch from 5017f24 to b59394d Compare April 24, 2024 13:03
@kean kean merged commit 893bb0a into trunk Apr 24, 2024
24 checks passed
@kean kean deleted the task/revert-pending-change branch April 24, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants