-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Notifications Refresh] Redesign Likes and Follows details content #23178
Merged
justtwago
merged 12 commits into
feature/notifications_refresh_p2
from
task/likes-details-list-redesign
May 16, 2024
Merged
[Notifications Refresh] Redesign Likes and Follows details content #23178
justtwago
merged 12 commits into
feature/notifications_refresh_p2
from
task/likes-details-list-redesign
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
alpavanoglu
reviewed
May 10, 2024
Modules/Sources/DesignSystem/Foundation/Icons.xcassets/reader.follow.imageset/Contents.json
Outdated
Show resolved
Hide resolved
Modules/Sources/DesignSystem/Foundation/Icons.xcassets/reader.following.imageset/Contents.json
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Notifications/Views/NotificationDetailUserView.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Notifications/Views/NotificationDetailUserView.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Notifications/Views/NotificationDetailUserView.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Notifications/Views/NotificationDetailUserView.swift
Show resolved
Hide resolved
…d LikeUserTableViewCell
salimbraksa
reviewed
May 13, 2024
WordPress/Classes/ViewRelated/Notifications/Views/NotificationDetailUserView.swift
Outdated
Show resolved
Hide resolved
salimbraksa
reviewed
May 15, 2024
WordPress/Classes/ViewRelated/Notifications/Views/LikeUserTableViewCell.xib
Outdated
Show resolved
Hide resolved
salimbraksa
reviewed
May 15, 2024
WordPress/Classes/ViewRelated/Notifications/Views/NoteBlockUserTableViewCell.xib
Outdated
Show resolved
Hide resolved
salimbraksa
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
justtwago
merged commit May 16, 2024
54ff478
into
feature/notifications_refresh_p2
23 of 24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Automattic/wordpress-mobile/issues/17
The PR contains refreshed designs for Likes and Followers notifications content.
Please, note that there are no designs for Followers in Figma, so I reused the same design for Likes and moved an original "Subscribe/Unsubscribe" inline action button to the right corner as suggested here: p1714157934304609-slack-C06BWNSR02K.
One more thing I noticed was a bug related to the inline action buttons. After going to the user's blog, subscribing/unsubscribing it from the blog page, and returning to the notification details, the inline action button doesn't change its state. Overall, the subscribe status is unpredictable and buggy, but I believe these bugs have to be resolved in a separate PR and are out of scope.
To test:
Regression Notes
Potential unintended areas of impact
Other notification details
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual tests
What automated tests I added (or what prevented me from doing so)
I couldn't add tests to the legacy code
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: