-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In-App Updates: Show flexible update again after a specified interval #23221
Conversation
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
096c3a1
to
4612cd3
Compare
26dc1da
to
352fe35
Compare
@kean - I made some changes to show the flexible update less often, as discussed in p1716217030223529-slack-C072JBZL84U. I'll ask to get the flexible update interval remote config value changed to 90 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested lastFetchedAppStoreInfoDate
logic – works great, and I think it's a good addition 👍
Part of https://github.com/Automattic/wordpress-mobile/issues/56
Description
Ref: p1715166447222309-slack-C072JBZL84U
How to test
Preconditions
In-App Updates
remote feature flagdelayInDays
default value to 1Test 1.1
Potential unintended areas of impact
Flexible/blocking update logic
What I did to test those areas of impact (or what existing automated tests I relied on)
Added a test
What automated tests I added (or what prevented me from doing so)
AppUpdateCoordinatorTests
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: