Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds os_version parameter in feature flags and dynamic dashboard cards #23319

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

antonis
Copy link

@antonis antonis commented Jun 6, 2024

Depends on: wordpress-mobile/WordPressKit-iOS#810

Description

Adds os_version parameter in feature flags and dynamic dashboard cards endpoints

Internal ref: pcdRpT-6Xn-p2

⚠️ Please remove the [Status] DO NOT MERGE label and merge after:

To test:

  • Follow the instruction in D150987-code
  • Sandbox your device
  • Verify that the OS Version Test iOS card is visible for devices with iOS version >= 16
  • Inspect the network traffic to verify that the test_os_version_rules_3 feature flag is true

Regression Notes

  1. Potential unintended areas of impact

    • Dynamic Dashboard cards and Feature flags
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing
  3. What automated tests I added (or what prevented me from doing so)

    • Updated the existing WPiOSkit tests

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dangermattic
Copy link
Collaborator

dangermattic commented Jun 6, 2024

1 Warning
⚠️ This PR is assigned to the milestone 25.1. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@antonis antonis marked this pull request as ready for review June 6, 2024 13:48
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 6, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23319-b951cf0
Version25.0
Bundle IDcom.jetpack.alpha
Commitb951cf0
App Center Buildjetpack-installable-builds #9161
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 6, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23319-b951cf0
Version25.0
Bundle IDorg.wordpress.alpha
Commitb951cf0
App Center BuildWPiOS - One-Offs #10112
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@antonis antonis added this to the 25.1 milestone Jun 6, 2024
@antonis antonis force-pushed the task/os-version-rules branch from 45c0634 to b951cf0 Compare June 7, 2024 07:46
@antonis antonis enabled auto-merge June 7, 2024 08:03
@antonis antonis merged commit d64d728 into trunk Jun 7, 2024
21 of 24 checks passed
@antonis antonis deleted the task/os-version-rules branch June 7, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants