Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append "+testing" to feedback form email for Automatticians #23804

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

crazytonyli
Copy link
Contributor

Fixes #23794

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@crazytonyli crazytonyli added Support User Feedback Users need something added or fixed labels Nov 14, 2024
@crazytonyli crazytonyli added this to the 25.6 milestone Nov 14, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 25.6. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23804-f16e98d
Version25.4.2
Bundle IDcom.jetpack.alpha
Commitf16e98d
App Center Buildjetpack-installable-builds #10084
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23804-f16e98d
Version25.4.2
Bundle IDorg.wordpress.alpha
Commitf16e98d
App Center BuildWPiOS - One-Offs #11044
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

let atSymbolIndex = email.index(email.endIndex, offsetBy: -suffix.count)

// Do nothing if the email is already an "alias email".
if email[email.startIndex..<atSymbolIndex].contains("+") {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@kean kean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks OK as a workaround but the target state is update support to require you to be authorized, so it's likely a waste.

@crazytonyli crazytonyli added this pull request to the merge queue Nov 14, 2024
Merged via the queue into trunk with commit dfdc8de Nov 14, 2024
26 of 27 checks passed
@crazytonyli crazytonyli deleted the fix/issue-23794-a8c-alias-email branch November 14, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Support User Feedback Users need something added or fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Append "+testing" to feedback form email for Automatticians
5 participants