Refactor: Remove flipInsetsForRightToLeftLayoutDirection #23811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
kean
commented
Nov 14, 2024
| @@ -385,7 +385,6 @@ private extension CommentContentTableViewCell { | |||
| replyButton?.setTitleColor(Style.reactionButtonTextColor, for: .normal) | |||
| replyButton?.setImage(Style.replyIconImage, for: .normal) | |||
| replyButton?.addTarget(self, action: #selector(replyButtonTapped), for: .touchUpInside) | |||
| replyButton?.flipInsetsForRightToLeftLayoutDirection() | |||
There was a problem hiding this comment.
This had no effect because the buttons are vertical.
The layout is a bit broken. I reported it here #23812.
| @@ -376,17 +374,6 @@ class ReaderDetailToolbar: UIView, NibLoadable { | |||
| configureActionButtonStyle(saveForLaterButton) | |||
| } | |||
|
|
|||
| private func adjustInsetsForTextDirection() { | |||
There was a problem hiding this comment.
This change also had no effect because these button are vertical.
| @@ -78,7 +78,6 @@ class JetpackButton: CircularImageButton { | |||
| imageEdgeInsets = Appearance.iconInsets | |||
| contentEdgeInsets = Appearance.contentInsets | |||
| imageView?.contentMode = .scaleAspectFit | |||
| flipInsetsForRightToLeftLayoutDirection() | |||
There was a problem hiding this comment.
Don't have screenshots, but it should be OK.
I'm planning to remove the remaining usages of JetpackButton next week together with sone of the Jetpack migration code.
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23811-9772eb1 | |
| Version | 25.4.2 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 9772eb1 | |
| App Center Build | WPiOS - One-Offs #11053 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23811-9772eb1 | |
| Version | 25.4.2 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 9772eb1 | |
| App Center Build | jetpack-installable-builds #10093 |
crazytonyli
approved these changes
Nov 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few warnings.
To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: