Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in UserProfileSheetViewController #23833

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented Nov 19, 2024

Fixes #21084 (https://a8c.sentry.io/issues/3804144050/?environment=appStore&project=5716771&query=release%3Acom.automattic.jetpack%4025.4.2%2B25.4.2.0&referrer=release-issue-stream). It is a pretty common crash. I hope it only affects this screen, and it does seem to be the case based on the callstacks.

Screenshot 2024-11-19 at 6 33 53 PM Screenshot 2024-11-19 at 6 39 03 PM

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the General label Nov 19, 2024
@kean kean added this to the 25.5 milestone Nov 19, 2024
@kean kean requested a review from crazytonyli November 19, 2024 23:41
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 25.5. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger


// Apply a slight padding to the bottom of the view to give it some space to breathe
// when being presented in a popover or bottom sheet
let bottomPadding = WPDeviceIdentification.isiPad() ? Constants.iPadBottomPadding : Constants.iPhoneBottomPadding
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting rid of one more incorrect use of WPDeviceIdentification.isiPad() 🥳

@kean kean enabled auto-merge November 19, 2024 23:46
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23833-48a31aa
Version25.4.2
Bundle IDorg.wordpress.alpha
Commit48a31aa
App Center BuildWPiOS - One-Offs #11081
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23833-48a31aa
Version25.4.2
Bundle IDcom.jetpack.alpha
Commit48a31aa
App Center Buildjetpack-installable-builds #10122
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean added this pull request to the merge queue Nov 20, 2024
Merged via the queue into trunk with commit 7f0b34d Nov 20, 2024
26 checks passed
@kean kean deleted the fix/crash-in-bottom-presentation-vc branch November 20, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants