Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BottomSheetViewController from reader conversation settings #23840

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented Nov 20, 2024

Removing BottomSheetViewController from more places to make sure no other crashes related to it happen.

  • Open Reader
  • Open a post
  • Open comments
  • Tap "Follow" and wait for success
  • Tap the bell to open conversation settings
  • Verify that its displayed OK
Screenshot 2024-11-20 at 11 17 10 AM Screenshot 2024-11-20 at 11 20 20 AM

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Reader label Nov 20, 2024
@kean kean added this to the Pending milestone Nov 20, 2024
@kean kean requested a review from crazytonyli November 20, 2024 16:22
return
}

ActionDispatcher.dispatch(locked ? NoticeAction.lock : NoticeAction.unlock)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was safer to just remove it, including the WPDeviceIdentification.isiPhone() and reliance on dismiss callbacks. I don't see a big deal showing a notice here.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23840-e68e676
Version25.4.2
Bundle IDorg.wordpress.alpha
Commite68e676
App Center BuildWPiOS - One-Offs #11097
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23840-e68e676
Version25.4.2
Bundle IDcom.jetpack.alpha
Commite68e676
App Center Buildjetpack-installable-builds #10136
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean enabled auto-merge November 20, 2024 20:21
@kean kean added this pull request to the merge queue Nov 21, 2024
Merged via the queue into trunk with commit e5f9067 Nov 21, 2024
26 checks passed
@kean kean deleted the task/remove-bottom-sheet-vc branch November 21, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants