Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TikTok Embeds in Reader #23841

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

jkmassel
Copy link
Contributor

Fixes #

To test:

  1. View http://jutgh.art.blog/2024/11/20/tiktok-embed-test/ in Reader
  2. Note that the TikTok and Twitter embeds work

Regression Notes

  1. Potential unintended areas of impact
    n/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dangermattic
Copy link
Collaborator

dangermattic commented Nov 20, 2024

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is assigned to the milestone 25.5. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23841-5054bea
Version25.4.2
Bundle IDorg.wordpress.alpha
Commit5054bea
App Center BuildWPiOS - One-Offs #11096
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@jkmassel jkmassel added this to the 25.5 milestone Nov 20, 2024
@jkmassel jkmassel enabled auto-merge November 20, 2024 17:05
@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23841-5054bea
Version25.4.2
Bundle IDcom.jetpack.alpha
Commit5054bea
App Center Buildjetpack-installable-builds #10137
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@jkmassel jkmassel added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2024
@jkmassel jkmassel added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2024
@crazytonyli crazytonyli added this pull request to the merge queue Nov 21, 2024
Merged via the queue into trunk with commit 4bc03da Nov 22, 2024
27 checks passed
@crazytonyli crazytonyli deleted the enable/tiktok-embeds-in-reader branch November 22, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants