Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Enhance loading experience in post details #23852

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented Nov 21, 2024

The current implementation is not great because:

  1. We already have everything we need to display the post we just need to wait for the web view to finish
  2. The skeleton view is a bit wacky with weird shapes and spacing

In the new version, the app displays everything it has immediately and just shows the spinner covering the web view.

loading-before.mp4
loading-after.mp4

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Reader label Nov 21, 2024
@kean kean added this to the 25.5 milestone Nov 21, 2024
@kean kean force-pushed the task/reader-enhance-loading-view branch from 79a0dab to 16dbb81 Compare November 21, 2024 19:15
@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23852-16dbb81
Version25.4.2
Bundle IDcom.jetpack.alpha
Commit16dbb81
App Center Buildjetpack-installable-builds #10151
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23852-16dbb81
Version25.4.2
Bundle IDorg.wordpress.alpha
Commit16dbb81
App Center BuildWPiOS - One-Offs #11111
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 25.5. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@kean kean enabled auto-merge November 21, 2024 20:32
@kean kean requested a review from crazytonyli November 21, 2024 20:32
@kean kean added this pull request to the merge queue Nov 21, 2024
Merged via the queue into trunk with commit 17fbafa Nov 22, 2024
21 of 24 checks passed
@kean kean deleted the task/reader-enhance-loading-view branch November 22, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants