Reader: Add a way to view posts that are restricted #23853
Conversation
kean
changed the title
| @@ -247,6 +247,12 @@ class ReaderDetailViewController: UIViewController, ReaderDetailView { | |||
|
|
|||
| webView.isP2 = post.isP2Type() | |||
|
|
|||
| if post.content?.hasSuffix("[…]") == true { | |||
There was a problem hiding this comment.
There gotta be a better way to test, but I couldn't find one. I think it'll do for now.
There was a problem hiding this comment.
Hey, @nbradbury, would you mind checking how the scenario from the PR is detected in Android?
There was a problem hiding this comment.
On Android, when the post is tapped in the list view we show the excerpt in the detail view, with a link at the bottom to visit the site for the full post.
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23853-0ae4947 | |
| Version | 25.4.2 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 0ae4947 | |
| App Center Build | WPiOS - One-Offs #11113 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23853-0ae4947 | |
| Version | 25.4.2 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 0ae4947 | |
| App Center Build | jetpack-installable-builds #10153 |
kean
changed the title
|
I wonder if a generic |
| .font: UIFont.preferredFont(forTextStyle: .body), | ||
| .foregroundColor: UIColor.label | ||
| ]) | ||
| let range = string.mutableString.range(of: "%@") |
There was a problem hiding this comment.
I guess we'd just have to hope the %@ in the original format doesn't get translated into %1$@.
Probably not for this PR, but it should not be too difficult to find out the difference between the String format and the formatted string, and compute the argument values positions in the final String.
func formattedString(format: String, args: [Any]) -> (final: String, argsRange: [Range])
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
Version |
Fixes #23638 by adding support for posts that can't be viewed in the Reader.
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-21.at.16.03.55.mp4
To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: