Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Fix layout for cross-post cells on iPad #23879

Closed
wants to merge 2 commits into from
+44 −14
Closed

Reader: Fix layout for cross-post cells on iPad #23879

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d1117f
Remove makeSelectedBackgroundView
kean Dec 10, 2024
ede3bbc
Fix layout for cross-post cells
kean Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove makeSelectedBackgroundView
  • Loading branch information
@kean
kean committed Dec 10, 2024
commit 2d1117ff1eb165ad574399dcf7c6a3eb6505ca2a
2 changes: 0 additions & 2 deletions WordPress/Classes/ViewRelated/Reader/Cards/ReaderCrossPostCell.swift
View file
Original file line number Diff line number Diff line change
@@ -32,8 +32,6 @@ final class ReaderCrossPostCell: ReaderStreamBaseCell {

setupStyle()
setupLayout()

selectedBackgroundView = ReaderPostCell.makeSelectedBackgroundView()
}

required init?(coder: NSCoder) {
6 changes: 0 additions & 6 deletions WordPress/Classes/ViewRelated/Reader/Cards/ReaderPostCell.swift
View file
Original file line number Diff line number Diff line change
@@ -23,12 +23,6 @@ final class ReaderPostCell: ReaderStreamBaseCell {
])
}

static func makeSelectedBackgroundView() -> UIView {
let view = UIView()
view.backgroundColor = UIColor.opaqueSeparator.withAlphaComponent(0.2)
return view
}

required init?(coder: NSCoder) {
fatalError("Not implemented")
}