Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Fix layout for cross-post cells on iPad #23880

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented Dec 10, 2024

There was an issue with the layout of these cells on iPad, presumably a result of an automatic merge of a bunch of the previous PRs. I fixed it by adopting the same implementation as in ReaderPostCell.

Not sharing the screenshots because it's P2-only.

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Reader label Dec 10, 2024
@kean kean requested a review from crazytonyli December 10, 2024 15:38
@kean kean changed the base branch from trunk to release/25.5 December 10, 2024 15:38
@dangermattic
Copy link
Collaborator

dangermattic commented Dec 10, 2024

1 Warning
⚠️ This PR is assigned to the milestone 25.5 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@kean kean added this to the 25.5 ❄️ milestone Dec 10, 2024
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23880-e010fe9
Version25.5
Bundle IDorg.wordpress.alpha
Commite010fe9
App Center BuildWPiOS - One-Offs #11153
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23880-e010fe9
Version25.5
Bundle IDcom.jetpack.alpha
Commite010fe9
App Center Buildjetpack-installable-builds #10192
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean merged commit f2bac5b into release/25.5 Dec 11, 2024
27 checks passed
@kean kean deleted the fix/reader-cell-layout branch December 11, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants