Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/25.5 into trunk #23898

Closed
wants to merge 17 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions RELEASE-NOTES.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
25.6
-----


25.6
-----
* [*] [internal] Update Gravatar SDK to 3.0.0 [#23701]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,49 @@
import Foundation
import AutomatticTracks
import WordPressShared
import WordPressUI

final class ReaderCrossPostCell: ReaderStreamBaseCell {
private let view = ReaderCrossPostView()
private var contentViewConstraints: [NSLayoutConstraint] = []

override init(style: UITableViewCell.CellStyle, reuseIdentifier: String?) {
super.init(style: style, reuseIdentifier: reuseIdentifier)

contentView.addSubview(view)
view.translatesAutoresizingMaskIntoConstraints = false
NSLayoutConstraint.activate([
view.topAnchor.constraint(equalTo: contentView.topAnchor),
view.bottomAnchor.constraint(equalTo: contentView.bottomAnchor).withPriority(999),
])
}

required init?(coder: NSCoder) {
fatalError("Not implemented")
}

override func prepareForReuse() {
super.prepareForReuse()

view.prepareForReuse()
}

func configure(with post: ReaderPost) {
view.configure(with: post)
}

override func didUpdateCompact(_ isCompact: Bool) {
setNeedsUpdateConstraints()
}

override func updateConstraints() {
NSLayoutConstraint.deactivate(contentViewConstraints)
contentViewConstraints = view.pinEdges(.horizontal, to: isCompact ? contentView : contentView.readableContentGuide)
super.updateConstraints()
}
}

private final class ReaderCrossPostView: UIView {
private let avatarView = ReaderAvatarView()
private let iconView = ReaderAvatarView()
private let headerLabel = UILabel()
Expand All @@ -27,22 +68,18 @@ final class ReaderCrossPostCell: ReaderStreamBaseCell {
.foregroundColor: UIColor.secondaryLabel
]

override init(style: UITableViewCell.CellStyle, reuseIdentifier: String?) {
super.init(style: style, reuseIdentifier: reuseIdentifier)
override init(frame: CGRect) {
super.init(frame: frame)

setupStyle()
setupLayout()

selectedBackgroundView = ReaderPostCell.makeSelectedBackgroundView()
}

required init?(coder: NSCoder) {
fatalError("Not implemented")
}

override func prepareForReuse() {
super.prepareForReuse()

func prepareForReuse() {
avatarView.prepareForReuse()
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import WordPressShared

final class ReaderPostCell: ReaderStreamBaseCell {
private let view = ReaderPostCellView()

private var contentViewConstraints: [NSLayoutConstraint] = []

static let avatarSize: CGFloat = SiteIconViewModel.Size.small.width
Expand All @@ -23,12 +22,6 @@ final class ReaderPostCell: ReaderStreamBaseCell {
])
}

static func makeSelectedBackgroundView() -> UIView {
let view = UIView()
view.backgroundColor = UIColor.opaqueSeparator.withAlphaComponent(0.2)
return view
}

required init?(coder: NSCoder) {
fatalError("Not implemented")
}
Expand Down
12 changes: 6 additions & 6 deletions WordPress/Jetpack/Resources/AppStoreStrings.po
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,13 @@ msgctxt "app_store_keywords"
msgid "social,notes,jetpack,writing,geotagging,media,blog,website,blogging,journal"
msgstr ""

msgctxt "v25.4-whats-new"
msgctxt "v25.5-whats-new"
msgid ""
"Three things this month:\n"
"1. We've updated the UI for iPadOS 18 – no more tab bar, everything is navigation-based, which should be a better use of the larger screen size.\n"
"2. Some iOS 18 improvements – a few color tweaks, some bugfixes, and most importantly – tintable icons!\n"
"3. We've been hard at work on an experimental new block editor. It's not ready for full-time use, but we'd love your feedback! Check it out in Me > App Settings > Experimental Features.\n"
"If you have feedback on any of these features, we'd love to hear it – reach out to us at [email protected]!\n"
"This month, we've:\n"
"- Fixed some crashes in reader, improved search, and made posts load more smoothly.\n"
"- Enabled TikTok embeds in reader.\n"
"- Stability improvements to the experimental editor (you should try it if you haven't already!)\n"
"- Adjusted how users log into WordPress.com – we hope it'll make it easier for folks to get started.\n"
msgstr ""

#. translators: This is a promo message that will be attached on top of the first screenshot in the App Store.
Expand Down
1 change: 1 addition & 0 deletions WordPress/Jetpack/Resources/beta_app_description.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Thanks for using the Jetpack TestFlight build – please feel free to send us any feedback you might have!
10 changes: 5 additions & 5 deletions WordPress/Jetpack/Resources/release_notes.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Three things this month:
1. We've updated the UI for iPadOS 18 – no more tab bar, everything is navigation-based, which should be a better use of the larger screen size.
2. Some iOS 18 improvements – a few color tweaks, some bugfixes, and most importantly – tintable icons!
3. We've been hard at work on an experimental new block editor. It's not ready for full-time use, but we'd love your feedback! Check it out in Me > App Settings > Experimental Features.
If you have feedback on any of these features, we'd love to hear it – reach out to us at [email protected]!
This month, we've:
- Fixed some crashes in reader, improved search, and made posts load more smoothly.
- Enabled TikTok embeds in reader.
- Stability improvements to the experimental editor (you should try it if you haven't already!)
- Adjusted how users log into WordPress.com – we hope it'll make it easier for folks to get started.
10 changes: 4 additions & 6 deletions WordPress/Resources/AppStoreStrings.po
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,11 @@ msgctxt "app_store_keywords"
msgid "blogger,writing,blogging,web,maker,online,store,business,make,create,write,blogs"
msgstr ""

msgctxt "v25.4-whats-new"
msgctxt "v25.5-whats-new"
msgid ""
"Three things this month:\n"
"1. We've updated the UI for iPadOS 18 – no more tab bar, everything is navigation-based, which should be a better use of the larger screen size.\n"
"2. Some iOS 18 improvements – a few color tweaks, some bugfixes, and most importantly – tintable icons!\n"
"3. We've been hard at work on an experimental new block editor. It's not ready for full-time use, but we'd love your feedback! Check it out in Me > App Settings > Experimental Features.\n"
"If you have feedback on any of these features, we'd love to hear it – reach out to us at [email protected]!\n"
"This month, we've:\n"
"- Stability improvements to the experimental editor (you should try it if you haven't already!)\n"
"- Adjusted how users log into WordPress.com – we hope it'll make it easier for folks to get started.\n"
msgstr ""

#. translators: This is a standard chunk of text used to tell a user what's new with a release when nothing major has changed.
Expand Down
Loading
Loading