Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with small tap area of the ellipsis in the post list #23973

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

kean
Copy link
Contributor

@kean kean commented Jan 13, 2025

Fixes #23970.

The button is now added to the top of the view hierarchy and covers the entire corner.

Screenshot 2025-01-13 at 5 01 34 PM

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dangermattic
Copy link
Collaborator

dangermattic commented Jan 13, 2025

1 Warning
⚠️ This PR is assigned to the milestone 25.7. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@kean kean added this to the 25.7 milestone Jan 13, 2025
@kean kean requested a review from crazytonyli January 13, 2025 22:10
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 13, 2025

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23973-50977bc
Version25.6
Bundle IDorg.wordpress.alpha
Commit50977bc
App Center BuildWPiOS - One-Offs #11346
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean enabled auto-merge January 13, 2025 22:58
@kean kean added this pull request to the merge queue Jan 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2025
@kean kean added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2025
@kean kean added this pull request to the merge queue Jan 14, 2025
@kean kean removed this pull request from the merge queue due to a manual request Jan 14, 2025
@kean kean enabled auto-merge January 14, 2025 16:33
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 14, 2025

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23973-50977bc
Version25.6
Bundle IDcom.jetpack.alpha
Commit50977bc
App Center Buildjetpack-installable-builds #10377
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean force-pushed the fix/tap-area-ellipsis-post-list branch from 8eed295 to 97ddf3c Compare January 14, 2025 20:06
@kean kean disabled auto-merge January 14, 2025 20:35
@kean kean enabled auto-merge January 14, 2025 20:36
@kean kean added this pull request to the merge queue Jan 14, 2025
Merged via the queue into trunk with commit 60677aa Jan 14, 2025
25 checks passed
@kean kean deleted the fix/tap-area-ellipsis-post-list branch January 14, 2025 21:30
jkmassel pushed a commit that referenced this pull request Jan 16, 2025
…3973)

* Fix an issue with small tap area of the ellipsis in the post list

* Update release notes

* Mark flaky testExitCallbackCalledWithLastSearchTextWhenCancelPressed

* Disable flaky test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button "More" in post list tap area is too small
4 participants