Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Send editor feedback #23980

Merged
merged 3 commits into from
Jan 16, 2025
Merged

feat: Send editor feedback #23980

merged 3 commits into from
Jan 16, 2025

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Jan 15, 2025

Collecting feedback from users while in editor may uncover valuable
insights.

Related:

To test:

  1. Open the experimentla editor.
  2. Tap the more button (three vertical dots) in the top-right corner.
  3. Tap Send Feedback.
  4. Submit feedback.
  5. Verify its delivery within the customer support system.

Regression Notes

  1. Potential unintended areas of impact
    None likely with this limited addition.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A.
  3. What automated tests I added (or what prevented me from doing so)
    N/A.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dcalhoun dcalhoun added [Type] Enhancement Gutenberg Editing and display of Gutenberg blocks. labels Jan 15, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 15, 2025

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@dcalhoun dcalhoun force-pushed the feat/send-editor-feedback branch from 05f391c to d65142a Compare January 15, 2025 16:26
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 15, 2025

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23980-532e533
Version25.6
Bundle IDorg.wordpress.alpha
Commit532e533
App Center BuildWPiOS - One-Offs #11358
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 15, 2025

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23980-532e533
Version25.6
Bundle IDcom.jetpack.alpha
Commit532e533
App Center Buildjetpack-installable-builds #10389
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@dcalhoun dcalhoun marked this pull request as ready for review January 15, 2025 18:04
@dcalhoun dcalhoun requested a review from kean January 15, 2025 18:04
@dcalhoun
Copy link
Member Author

I added an [Editor] prefix to feedback submissions originating from within the editor (20a7740) to mirror an update to the Android implementation: wordpress-mobile/WordPress-Android#21586 (comment)

Copy link
Contributor

@kean kean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The ordering/grouping of actions could be a bit better. I think the "support"-related items belong to a separate group at the bottom. But it's a nit pick, I'd just keep it as is. If more actions are added, it would make more sense to address the grouping.

Collecting feedback from users while in editor may uncover valuable
insights.
Indicate the context for feedback submissions originating from the
editor.
@dcalhoun dcalhoun force-pushed the feat/send-editor-feedback branch from 20a7740 to 532e533 Compare January 16, 2025 19:06
@dcalhoun dcalhoun enabled auto-merge January 16, 2025 19:06
@dcalhoun dcalhoun added this pull request to the merge queue Jan 16, 2025
Merged via the queue into trunk with commit 95e3c22 Jan 16, 2025
25 checks passed
@dcalhoun dcalhoun deleted the feat/send-editor-feedback branch January 16, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. [Type] Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants