Skip to content
This repository has been archived by the owner on Feb 5, 2025. It is now read-only.

[DO NOT MERGE] Magic link create account test #862

Closed
wants to merge 5 commits into from

Conversation

twstokes
Copy link
Contributor


  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@twstokes twstokes force-pushed the magic-link-create-account-test branch from 21f23b4 to dd8dd16 Compare November 20, 2024 14:41
@mokagio
Copy link
Contributor

mokagio commented Nov 21, 2024

Closing to keep the PRs list tidy. See last commit in #861 . TL;DR updating Podfile was good for development. But in order to have a ready-to-publish pod (which is what the validate .podspec CI step checks) we also needed to update the podspec. The podspec has to point to a published version, see https://guides.cocoapods.org/syntax/podspec.html#dependency, hence we also had to publish a new WordPressKit version wordpress-mobile/WordPressKit-iOS#823

Finally, this will all become redundant as soon as we implement woocommerce/woocommerce-ios#14329

@mokagio mokagio closed this Nov 21, 2024
@mokagio mokagio deleted the magic-link-create-account-test branch November 21, 2024 06:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants