-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up SwiftLint #693
Merged
Merged
Set up SwiftLint #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d898597
to
d13c749
Compare
crazytonyli
approved these changes
Jan 18, 2024
Thank you for the review @crazytonyli . FYI, I might hold onto this and try a different approach via SPM. We'll see... |
I used SwiftLint via SPM in wordpress-mobile/WordPress-iOS-Shared#344. It works well for libraries that are configured as Swift Packages, because you can add it to |
d13c749
to
b2fd35f
Compare
1 task
Well done! |
This was referenced Mar 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets up SwiftLint in the project, so it runs via build phase and can also run locally via Fastlane.
Context: I'm going through our Swift codebases to ensure:
Testing Details
Add some empty lines in a Swift file then build, you should see a warning.
Run
bundle exec fastlane lint
. It should fail:Run
bundle exec fastlane format
. It should pass and the empty line should be gone from XcodeCHANGELOG.md
if necessary. – N.A.