Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: html -> blocks #119

Merged
merged 31 commits into from
Aug 15, 2018
Merged

Feature: html -> blocks #119

merged 31 commits into from
Aug 15, 2018

Conversation

etoledom
Copy link
Contributor

This is the feature branch PR, all commits were already tested and approved on previous PRs.

This feature consist on:

  • Making the html view editable.
  • Translate changes made in the html source back into blocks.

Important notes:

  • Any html code that is not a registered Gutenberg block won't be parsed.
  • There are a few UX issues regarding the html editor that will be handled in the future. HTML TextInput UX issues #118

etoledom and others added 30 commits August 7, 2018 14:01
@etoledom
block-manager: HTML view is editable
5ac0d15
@etoledom
renderHTML: Fix android KeybardAvoidingView behavior
aee46ae
@etoledom
Merge pull request #94 from wordpress-mobile/feature/editable-html-view
3b77950 
Editable html view
@etoledom
Added action to parse html into blocks
c6b1b08
@etoledom
Merge branch 'master' into feature/editable-html-view-feature-branch
ae38602
@etoledom
Merge branch 'feature/editable-html-view-feature-branch' into feature…
8e26b60 
…/parse-html-into-blocks
@etoledom
Remove reducer dependency on parser
01be09f
@etoledom
Lint fixes
e7a7ff8
@etoledom
AppContainer: Removed unused parser property from mapStateToProps
885a47b
@etoledom
Minor code clean up
288178a
@etoledom
block-manager: added html property as a prop.
ce96e20 
Mainly to fix `flow` errors. Flow also doesn't like curried annotation :[
@etoledom
lint --fix
a9647ea
@etoledom
block-manager: removed parser and html from props
79935ed
@etoledom
block-manager: remove unnecesary componentDidMount
419e4fa
@etoledom
Actions: remove uid from parseBlocksAction
770eeaa
@etoledom
block-manager: Adding html as part of the component state
eb2a720
@etoledom
BlockListType: remove parser from parseBlocksAction
18acd22
@etoledom
fix parseBlocksAction test
75dd4bf
@etoledom
Merge branch 'master' into feature/parse-html-into-blocks
4aed861
@etoledom
Merge branch 'master' into feature/editable-html-view-feature-branch
d4d32c1
@etoledom
Merge branch 'feature/editable-html-view-feature-branch' into feature…
77b2c10 
…/parse-html-into-blocks
@etoledom
parseBlocksAction: rename payload to html
55716fe
@etoledom
reducer tests: Moved registerCoreBlocks() to beforeAll()
91ffa52
@etoledom
Merge branch 'master' into feature/editable-html-view-feature-branch
15c626a
@etoledom
merge submodule commit
cc6534a
@etoledom
Merge branch 'feature/editable-html-view-feature-branch' into feature…
1b79efb 
…/parse-html-into-blocks
@mzorz
restart datasource after full parse of html
586526b
@mzorz
Merge pull request #116 from wordpress-mobile/try/mario-full-parse
59db4ae 
HTML parser - restart datasource after full parse of html
@etoledom
Merge pull request #100 from wordpress-mobile/feature/parse-html-into…
2265ab4 
…-blocks

Parse html into known blocks
@etoledom
Merge branch 'master' into feature/editable-html-view-feature-branch
62abad3
@etoledom etoledom self-assigned this Aug 15, 2018
@etoledom etoledom requested a review from mzorz August 15, 2018 16:55
mzorz
mzorz approved these changes Aug 15, 2018
View reviewed changes
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as advertised. Thanks for creating #118 as discussed for follow up 👍
:shipit:

@etoledom etoledom merged commit bff65ad into master Aug 15, 2018
@etoledom etoledom deleted the feature/editable-html-view-feature-branch branch August 15, 2018 18:21
@etoledom etoledom mentioned this pull request Aug 15, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzorz mzorz mzorz approved these changes

Assignees

@etoledom etoledom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etoledom @mzorz