Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.89.0 #5485

Merged
merged 5 commits into from
Feb 23, 2023
Merged

Release 1.89.0 #5485

merged 5 commits into from
Feb 23, 2023

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Feb 16, 2023 •
edited
Loading

Release for Gutenberg Mobile 1.89.0

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

No new user-facing changes for this release.

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

This was referenced Feb 16, 2023
Merged
Merged
Merged
@geriux geriux marked this pull request as ready for review February 16, 2023 14:06
@geriux
Copy link
Contributor Author

geriux commented Feb 16, 2023

Both platforms have been smoke tested using the integration builds ✅

twstokes
twstokes approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @geriux! Thank you.

@geriux
Copy link
Contributor Author

geriux commented Feb 21, 2023 •
edited
Loading

🟢 Writing Flow checklist (Android)

Build: 21.8-rc-1
Device: Redmi Note 8T (OS 11)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@geriux
Copy link
Contributor Author

geriux commented Feb 21, 2023 •
edited
Loading

🟢 Unsupported Block Tests (Android)

Build: 21.8-rc-1
Device: Redmi Note 8T (OS 11)

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@geriux
Copy link
Contributor Author

geriux commented Feb 21, 2023 •
edited
Loading

🟢 Test Suite 4 (Android)

Build: 21.8-rc-1
Device: Redmi Note 8T (OS 11)

DarkMode - 2

  • Spacer block - Dark mode - TC004
  • Buttons block - Dark mode - TC005
  • Group - Dark mode - TC006
  • Columns - Dark mode - TC007

Group - 2

  • Group - Navigation up button works as expected - TC006
  • Group - Navigation down works according to parent-first approach - TC007
  • Group - Cross navigation between blocks works as expected - TC008
  • Group - Check if in DarkMode all components gets proper colors - TC009
  • Group - Check if nested Placeholder block can be replaced - TC014

Spacer - 1

  • Spacer block - Spacer in horizontal layout works as expected - TC001

Buttons - 4

  • Buttons block - Render custom text color - TC013
  • Buttons block - Render custom background color - TC012
  • Buttons block - Render gradient background color - TC014
  • Buttons block - Check if selection / caret color matches font color - TC016
  • Buttons block - The newly created Buttons has set background color to the theme-default color in preview - TC017

Buttons - 5

  • Buttons block - Edit text styles - TC005
  • Buttons block - Render theme colors - TC015
  • Buttons block - Settings: Change Button border radius - TC011

Buttons - 7

  • Buttons block - Link from the clipboard is presented as an option in the link picker - TC020
  • Buttons block - Toolbar link button is active when Button has link - TC018

Editor Theme - 2

  • Custom Gradients - Check that custom gradients load in the editor - TC004
  • Offline Support - TC005

Color Settings - 2

  • Pressing color swatch - TC004
  • Customize gradient color - TC005
  • Custom color picker - TC006

@dcalhoun
Copy link
Member

dcalhoun commented Feb 21, 2023 •
edited
Loading

🟢 Writing Flow checklist (iOS)

Build: 21.8.0.0 (TestFlight)
Device: iPhone SE (iOS 16.3.1)

General

Rich Text Format

Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@dcalhoun
Copy link
Member

dcalhoun commented Feb 21, 2023 •
edited
Loading

🔴 Unsupported Block Tests (iOS)

Build: 21.8.0.0 (TestFlight)
Device: iPhone SE (iOS 16.3.1)

@dcalhoun
Copy link
Member

dcalhoun commented Feb 21, 2023 •
edited
Loading

🔴 Test Suite 5 (iOS)

Build: 21.8.0.0 (TestFlight)
Device: iPhone SE (iOS 16.3.1)

Video block - 1

  • Video block - Insert video from device (failing) - steps
    ❗ New issue: p1677028872361079-slack-C6UJ0KRKQ
  • Video block - Close/Re-open post with an ongoing video upload - steps

Video block - 2

  • Video block - Insert video from device (cancel) - steps
  • Video block - Close post with an ongoing video upload - steps
  • Video block - Add Caption - steps

File block - 1

File block - 2

  • File block - Close the post with an ongoing file upload - steps
  • File block - Replace the selected files - steps
  • File block - Change the alignment in the File Block - steps
  • File block - The Link To Block Setting should open - steps

File block - 3

  • File block - Open link in new tab - steps
  • File block - Show/hide download button (Block Settings only) - steps
  • File block - Copy file URL - steps
  • File block - Close/Re-open post with an ongoing file upload - steps

Audio block - 1

  • Audio block - Upload completes successfully from the device library - steps
  • Audio block - Insert completes successfully from the WordPress Media library - steps

Audio block - 2

  • Audio block - Upload fails from the device library - steps
  • Audio block - Stop the audio file upload before it completes - steps

Audio block - 3

  • Audio block - Close the post with an ongoing audio file upload - steps
  • Audio block - Replace the selected files - steps
  • Audio block - Change the alignment in the Audio Block - steps

Audio block - 4

  • Audio block - Autoplay setting - steps
  • Audio block - Loop setting - steps
  • Audio block - Close/Re-open post with an ongoing audio file upload - steps

Reusable block - 1

  • Reusable block - Add block - steps
  • Reusable block - Convert to regular blocks - steps

Reusable block - 2

  • Reusable block - Deleted reusable block - steps
  • Reusable block - Recursive block rendering - steps

Embed block - 1

  • Embed block - Inline previews are rendered correctly for the top 5 most-used providers - steps

Embed block - 2

  • Embed block - Inline previews are rendered accordingly for each alignment option - steps

@geriux geriux merged commit 72d5d34 into trunk Feb 23, 2023
@geriux geriux deleted the release/1.89.0 branch February 23, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twstokes twstokes twstokes approved these changes

@dcalhoun dcalhoun dcalhoun approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geriux @dcalhoun @twstokes