Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Avoid sending invalid caret rect information. #619

Merged
merged 1 commit into from
Feb 20, 2019
Merged

[iOS] Avoid sending invalid caret rect information. #619

merged 1 commit into from
Feb 20, 2019

Conversation

SergioEstevao
Copy link
Contributor

Refs #559

This PR adds a fix to avoid sending invalid caret information that was breaking JS conversion.

@SergioEstevao SergioEstevao added the [Type] Bug Something isn't working label Feb 19, 2019
@SergioEstevao SergioEstevao added this to the Beta milestone Feb 19, 2019
diegoreymendez
diegoreymendez approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works beautifully.

@SergioEstevao SergioEstevao merged commit b28b394 into develop Feb 20, 2019
@SergioEstevao SergioEstevao deleted the issue/559_Shift_Enter_fix branch February 20, 2019 00:17
@hypest hypest changed the title Avoid sending invalid caret rect information. [iOS] Avoid sending invalid caret rect information. Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegoreymendez diegoreymendez diegoreymendez approved these changes

Assignees
No one assigned
Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
Beta
Development

Successfully merging this pull request may close these issues.
2 participants
@SergioEstevao @diegoreymendez