Classic block: Add option to convert to blocks #6306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
commented
Oct 20, 2023
| @@ -179,7 +180,6 @@ | |||
| <string name="gutenberg_native_failed_to_save_files_please_tap_for_options" tools:ignore="UnusedResources">Failed to save files.\nPlease tap for options.</string> | |||
| <string name="gutenberg_native_failed_to_upload_files_please_tap_for_options" tools:ignore="UnusedResources">Failed to upload files.\nPlease tap for options.</string> | |||
| <string name="gutenberg_native_featured" tools:ignore="UnusedResources">Featured</string> | |||
| <string name="gutenberg_native_featured_image" tools:ignore="UnusedResources">Featured Image</string> | |||
There was a problem hiding this comment.
The removal of this string is expected as it's now also used in the web version (reference). Hence, it will be translated as part of the Gutenberg plugin.
|
@derekblank I decided to create the companion GBM PR to check and update the strings localization files. Let me know if you could take a quick look. Thanks 🙇 ! |
derekblank
approved these changes
Oct 23, 2023
# Conflicts: # gutenberg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to WordPress/gutenberg#55461.
To test:
Follow testing instructions from WordPress/gutenberg#55461.
PR submission checklist: