Use HTTP1.1 to download nodejs package #6348
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Sometimes on CI, we got the following error (here is an example) from installing node:
Even though the error is originated from nvm, but it doesn't appear to be an issue in nvm. The same issue appears in n too, which is a similar tool as nvm. And, it's likely an issue in the node.js package CDN (https://nodejs.org/dist).
Changes
I have added a new
curlrc
option to the nvm plugin, so that we can pass extra curl arguments to the curl commands invoked by nvm. This PR set the new option to--http1.1
, which should make nvm downloads nodejs packages using HTTP1.1 instead of HTTP2 protocol, which hopefully would resolve the aforementioned errors on CI.Test Instructions
This PR can be merged as long as CI jobs pass.
PR submission checklist: