Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken appearance of video blocks that were first created on the web #6371

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Nov 10, 2023

Fixes a problem in which video blocks that were first created on the web appear broken when viewed in the app.

For further information and to test, please refer to the central Jetpack PR available at Automattic/jetpack#34073


PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@SiobhyB SiobhyB added Video block Jetpack Bug or feature related to Jetpack labels Nov 10, 2023
@SiobhyB SiobhyB marked this pull request as ready for review November 10, 2023 18:43
@SiobhyB SiobhyB requested a review from derekblank November 13, 2023 07:43
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Nov 13, 2023

@derekblank, would you be able to take a look at this companion PR to the Jetpack fix? 🙇‍♀️

Copy link
Contributor

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SiobhyB SiobhyB enabled auto-merge November 13, 2023 07:52
@SiobhyB SiobhyB merged commit b22dd84 into trunk Nov 13, 2023
@SiobhyB SiobhyB deleted the jetpack/set-default-src-for-converted-video-block branch November 13, 2023 08:41
@fluiddot fluiddot mentioned this pull request Nov 23, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Bug or feature related to Jetpack Video block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants