Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add visual screenshot reference to README #6380

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Add visual screenshot reference to README #6380

merged 2 commits into from
Nov 16, 2023

Conversation

derekblank
Copy link
Contributor

@derekblank derekblank commented Nov 15, 2023 •
edited
Loading

Fixes:

To test:
View project README.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.
Screenshot 2023-11-15 at 6 50 24 pm

@derekblank derekblank linked an issue Nov 15, 2023 that may be closed by this pull request
Showcase the editor visually in the README #6362
Closed
@derekblank derekblank requested a review from twstokes November 15, 2023 08:04
twstokes
twstokes approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @derekblank! Thanks for adding this.

@derekblank derekblank merged commit aa5831d into trunk Nov 16, 2023
@derekblank derekblank deleted the docs/showcase-the-editor-visually-in-the-readme branch November 16, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twstokes twstokes twstokes approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Showcase the editor visually in the README
2 participants
@derekblank @twstokes