Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Improve E2E test stability #6569

Merged
merged 5 commits into from
Jan 25, 2024
Merged

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Jan 23, 2024

Related

Description

test: Update copy and paste test screenshot
Recapture the screenshot with an emulator the hides the device frame.

test: Mitigate test instability from arbitrary scroll positions
Scrolling to the bottom of the content is likely more consistent than an
arbitrary position that seems to vary between local environments and CI
servers.

Testing Instructions

N/A, CI checks should pass consistently.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@dcalhoun dcalhoun added the Testing Anything related to automated tests label Jan 23, 2024
Recapture the screenshot with an emulator the hides the device frame.
@dcalhoun dcalhoun force-pushed the test/improve-e2e-test-stability branch from 201b325 to 96b9da0 Compare January 24, 2024 01:13
@dcalhoun dcalhoun changed the title test: Improve E2E test stability test: Capture copy and paste screenshot without device frame Jan 24, 2024
Scrolling to the bottom of the content is likely more consistent than an
arbitrary position that seems to vary between local environments and CI
servers.
@dcalhoun dcalhoun changed the title test: Capture copy and paste screenshot without device frame test: Improve E2E test stability Jan 24, 2024
@dcalhoun dcalhoun marked this pull request as ready for review January 24, 2024 13:50
@dcalhoun dcalhoun requested a review from geriux January 24, 2024 13:51
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@dcalhoun dcalhoun enabled auto-merge January 25, 2024 14:00
@dcalhoun dcalhoun merged commit 00d99bd into trunk Jan 25, 2024
19 of 20 checks passed
@dcalhoun dcalhoun deleted the test/improve-e2e-test-stability branch January 25, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Anything related to automated tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants