Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Disables saving react root view from parent #6575

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

antonis
Copy link

@antonis antonis commented Jan 25, 2024

Related PRs:
WordPress-Android PR: wordpress-mobile/WordPress-Android#20046
Gutenberg PR: WordPress/gutenberg#58266

To test:
See wordpress-mobile/WordPress-Android#20046

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@antonis antonis marked this pull request as ready for review January 26, 2024 15:35
@antonis antonis requested a review from geriux January 26, 2024 15:35
@antonis antonis removed the [Status] DO NOT MERGE Do not merge this PR label Jan 26, 2024
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geriux
Copy link
Contributor

geriux commented Jan 30, 2024

Friendly reminder we first need to merge the Gutenberg PR, then update this PR with the merge commit from Gutenberg's trunk

@antonis antonis merged commit eeb8082 into trunk Jan 30, 2024
20 checks passed
@antonis antonis deleted the fix/android-disable-reactview-saving branch January 30, 2024 18:08
@derekblank derekblank mentioned this pull request Feb 1, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants