Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate the problem of moving the current block down sets the caret to the wrong block #802

Conversation

daniloercoli
Copy link
Contributor

This PR does help on mitigating the problem reported in #311, where under some circumstances the caret is moved to another block when the current TextInput powered block in moved down by the user. The problem was originally reported for Android, but it seems could happen on iOS too, even though with less frequency.

In this PR we're just hiding the Keyboard on block Up/Down/Delete operations.

A GIF of the original problem

focus-wrong

During my tentative to fix the problem I've also found other scenarios where the same issue comes up on writing.
IE:

To test

  • Start the demo app
  • Select a RichText block that is not the first in thelist, IE. Hello World block
  • Tap the down arrow on the toolbar
  • The block is correctly moved down and the keyboard dismissed

@daniloercoli daniloercoli self-assigned this Apr 2, 2019
@daniloercoli daniloercoli requested review from Tug and mzorz April 2, 2019 08:41
@daniloercoli daniloercoli added this to the v1.2 milestone Apr 5, 2019
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daniloercoli daniloercoli merged commit 1729d5d into develop Apr 5, 2019
@daniloercoli daniloercoli deleted the issue/311-Moving-block-down-shift-the-caret-on-the-wrong-block- branch April 5, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants