Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: type checks for JavaScript #976

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

cli: type checks for JavaScript #976

wants to merge 3 commits into from

Conversation

sonnyp
Copy link
Contributor

@sonnyp sonnyp commented Jul 19, 2024

No description provided.

sonnyp
sonnyp commented Jul 19, 2024
View reviewed changes
src/cli/main.js
uri,
lspc: lsp_clients.javascript,
});
diagnostics = diagnostics.filter((diagnostic) => {
return ![
"'await' has no effect on the type of this expression.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore errors on

Gio._promisify(foo, 'bar');

await foo.bar(...)

@sonnyp sonnyp changed the title cli: type checks cli: type checks for JavaScript Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sonnyp