-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Celery as an executor and refactor threading logic #41
Open
torkashvand
wants to merge
7
commits into
main
Choose a base branch
from
feature/add-celery-as-executor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+410
−248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
torkashvand
commented
Nov 11, 2024
- Implement Celery for task execution
- Refactor code to improve thread handling and structure
torkashvand
force-pushed
the
feature/add-celery-as-executor
branch
3 times, most recently
from
November 11, 2024 13:45
cb6aaff
to
56d491f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
+ Coverage 85.71% 86.98% +1.26%
==========================================
Files 7 9 +2
Lines 133 169 +36
Branches 6 12 +6
==========================================
+ Hits 114 147 +33
Misses 15 15
- Partials 4 7 +3 ☔ View full report in Codecov by Sentry. |
torkashvand
force-pushed
the
feature/add-celery-as-executor
branch
16 times, most recently
from
November 12, 2024 11:13
f37f48a
to
6f3f0f9
Compare
torkashvand
changed the title
DRAFT:Add Celery as an executor and refactor threading logic
Add Celery as an executor and refactor threading logic
Nov 12, 2024
torkashvand
force-pushed
the
feature/add-celery-as-executor
branch
2 times, most recently
from
November 13, 2024 16:19
30c8e15
to
12895fe
Compare
kvklink
reviewed
Nov 13, 2024
torkashvand
force-pushed
the
feature/add-celery-as-executor
branch
from
November 14, 2024 14:03
b897107
to
c66829c
Compare
kvklink
approved these changes
Nov 14, 2024
- Implement Celery for task execution - Refactor code to improve thread handling and structure
Co-authored-by: Karel van Klink <[email protected]>
Add input validation to sanitize data at API level. Write a test for incorrect playbook paths.
torkashvand
force-pushed
the
feature/add-celery-as-executor
branch
from
November 14, 2024 14:35
8587a2b
to
8d9a0f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.