Fix product id check in process detail (#251)

- null type is object, so correctly added it to as type and check if product is not false.
workfloworchestrator · Oct 3, 2023 · 00bb233 · 00bb233
1 parent 61a752d
commit 00bb233
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/pages/ProcessDetail.tsx b/src/pages/ProcessDetail.tsx
@@ -78,10 +78,12 @@ function ProcessDetail({ match, query, setQuery }: IProps) {
         if (stepUserInput && localStepUserInput) return;
         const localTabs = localStepUserInput ? ["user_input", "process"] : ["process"];
         const localSelectedTab = localStepUserInput ? "user_input" : "process";
-        const getProductId = (product: string | { product_id: string }) =>
-            typeof product === "object" ? product.product_id : product;
+        const getProductId = (product: string | { product_id: string } | null) =>
+            product && typeof product === "object" ? product.product_id : product;
         const product_id = getProductId(processInstance.product);
-        setProductName(productNameById(product_id, products));
+        if (product_id) {
+            setProductName(productNameById(product_id, products));
+        }
         setCustomerName(organisationNameByUuid(processInstance.customer, organisations));
         setProcess(processInstance);
         setStepUserInput(localStepUserInput);

diff --git a/src/utils/types.ts b/src/utils/types.ts
@@ -234,7 +234,7 @@ export interface Process {
 export interface ProcessWithDetails {
     id: string;
     workflow_name: string;
-    product: string | { product_id: string };
+    product: string | { product_id: string } | null;
     customer: string;
     assignee: Assignee;
     last_status: string;