Fix UI Refresh Issue due to product_id Type Variance (#248)

* Handle varying product_id types to prevent UI refresh interruptions * make product comparesion more genaral --------- Co-authored-by: Mohammad Torkashvand <[email protected]>
workfloworchestrator · Oct 3, 2023 · d10cc88 · d10cc88
1 parent 88c4a7c
commit d10cc88
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/pages/ProcessDetail.tsx b/src/pages/ProcessDetail.tsx
@@ -78,8 +78,10 @@ function ProcessDetail({ match, query, setQuery }: IProps) {
         if (stepUserInput && localStepUserInput) return;
         const localTabs = localStepUserInput ? ["user_input", "process"] : ["process"];
         const localSelectedTab = localStepUserInput ? "user_input" : "process";
-
-        setProductName(productNameById(processInstance.product, products));
+        const getProductId = (product: string | { product_id: string }) =>
+            typeof product === 'object' ? product : product.product_id;
+        const product_id = getProductId(processInstance.product);
+        setProductName(productNameById(product_id, products));
         setCustomerName(organisationNameByUuid(processInstance.customer, organisations));
         setProcess(processInstance);
         setStepUserInput(localStepUserInput);

diff --git a/src/utils/types.ts b/src/utils/types.ts
@@ -234,7 +234,7 @@ export interface Process {
 export interface ProcessWithDetails {
     id: string;
     workflow_name: string;
-    product: string;
+    product: string | { product_id: string };
     customer: string;
     assignee: Assignee;
     last_status: string;