Bubble up exceptions happening when handling events #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meziantou
reviewed
Feb 21, 2025
src/Workleap.DomainEventPropagation.Subscription.PullDelivery/EventPullerService.cs
Outdated
Show resolved
Hide resolved
src/Workleap.DomainEventPropagation.Subscription.PullDelivery/EventPullerService.cs
Outdated
Show resolved
Hide resolved
src/Workleap.DomainEventPropagation.Subscription.PullDelivery/EventPullerService.cs
Outdated
Show resolved
Hide resolved
Gcaya
reviewed
Feb 21, 2025
src/Workleap.DomainEventPropagation.Subscription.PullDelivery/EventPullerService.cs
Show resolved
Hide resolved
Gcaya
reviewed
Feb 21, 2025
src/Workleap.DomainEventPropagation.Subscription.PullDelivery/EventPullerService.cs
Outdated
Show resolved
Hide resolved
added 2 commits
February 21, 2025 11:36
meziantou
reviewed
Feb 21, 2025
src/Workleap.DomainEventPropagation.Subscription.PullDelivery/EventPullerService.cs
Outdated
Show resolved
Hide resolved
meziantou
approved these changes
Feb 25, 2025
Le-Merle
deleted the
feature/SGPD-1770_Bubble-Up-Errors-On-PullDelivery
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Using Task.WhenAll() will wait until every task is in a completed state before returning. This is problematic when a single subscription crashes, as we would normally expect the exception to bubble up to the IHost and crash it, thus enabling the entire app to be restarted, but it's not happening as long as at least one subscription hasn't crashed out.
This replaces Task.WhenAll() with a system that immediately bubbles up the first exception encountered.
Breaking changes
In theory, a pod that was running this background service would survive a crash in a subscription as long as any other subscription didn't crash. With this change, the pod is expected to crash entirely, enabling k8s to detect the broken state and restart it.
Additional checks