Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Compare computatation token versions in Millbase during exception handling. #1920

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renjiezh
Copy link
Contributor

@renjiezh renjiezh commented Nov 14, 2024

The computation token could be updated by Herald of ControlService. The error handling should skip for outdated computation token.
fix #1918

@wfa-reviewable
Copy link

This change is Reviewable

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @renjiezh)


src/main/kotlin/org/wfanet/measurement/duchy/mill/MillBase.kt line 278 at r1 (raw file):

    if (latestToken.version != token.version) {
      logger.log(Level.WARNING, e) {
        "$globalId@$millId: Skip exception handling as token has been outdated."

I don't think we want to skip all exception handling. For example, handling StatusException. I think the main thing we want to avoid is trying to mutate or enqueue the computation.

You can probably solve this by just checking for StatusException first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mill's exception handler should compare the token version before enqueuing it.
3 participants