#2112 - add option to configure priority fees #2128
Conversation
sebastianscatularo
commented
May 23, 2024
sebastianscatularo
commented
- expose option to set priority fees percentile
- expose function to compute priority fees with an alternative mechanism
✅ Deploy Preview for wormhole-connect ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wormhole-connect-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| async function determinePriorityFee( | ||
| connection: Connection, | ||
| lockedWritableAccounts: PublicKey[] = [], | ||
| percentile: number, | ||
| customDeterminePriorityFee: ( |
There was a problem hiding this comment.
I don't see how it would be useful to an integrator because we're not providing the connection to this custom function, only the addresses. they can't do much with only addresses unless they're providing their own connection.
also, the way you're using it here is you're just setting the default value using it, rather than the final value. it will still get overridden by our own logic, which follows it in this function starting on line 115. so this doesn't seem like it will even work.
It seems to me we want to either:
- let integrators completely override the
determinePriorityFeefunction - or let them just provide a custom percentile and keep our logic the same
this code change is sort of a weird combination of the two.
I would keep things simple and go with option 2 for now. can we just remove this custom callback function, and only add the percentile number as a new config option?
if there's need for deeper customizability in the future we can revisit overriding determineComputeBudget later.
There was a problem hiding this comment.
So this solution wont' work? I asked @barnjamin about this functionality but i'm having problems trying to clone this commit and installing it to my react app so i couldn't test it, and as i see it didn't merged to development brach yet right?
There was a problem hiding this comment.
good call. I’ll add it as a parameter. The idea is to allow integrators to use a different API, like what Helius provides for estimating priority fees, or any custom solution that someone might want to try, the limit is the skies 😅
There was a problem hiding this comment.
I think it would be good to offer both: custom percentile, or custom determinePriorityFee function altogether.
