Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing message index mutation #378

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix missing message index mutation #378

merged 1 commit into from
Sep 23, 2024

Conversation

bingyuyap
Copy link
Contributor

This PR does a few things:

  • fixes missing observation bug where monitor cannot find unprocessed messages as message indexes weren't created in FlushCache.
  • logs the bulk mutation for more observability.
  • updates MAX_CHAIN_ID to be the largest mainnet chain id.

@bingyuyap
hum: add message index bulk mutation that was hum
f3442d4 
hum: update MAX_CHAIN_ID

Signed-off-by: bingyuyap <[email protected]>
@bingyuyap bingyuyap merged commit d090941 into main Sep 23, 2024
3 checks passed
@bingyuyap bingyuyap deleted the bing/hum-missing-message-index-mutations branch September 23, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrogana lrogana lrogana approved these changes

@panoel panoel panoel approved these changes

@bruce-riley bruce-riley bruce-riley approved these changes

@evan-gray evan-gray Awaiting requested review from evan-gray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bingyuyap @lrogana @panoel @bruce-riley