Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ilariae/token bridge #96

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from
Draft

Ilariae/token bridge #96

wants to merge 25 commits into from

Conversation

ilariae
Copy link
Collaborator

@ilariae ilariae commented Sep 23, 2024

Description

Added Build > Contract integrations > Get started with Token bridge page
Heavily updated Learn > Messaging > Token Bridge page

Checklist

  • Required - I have added a label to this PR 🏷️
  • Required - I have run my changes through Grammarly
  • If pages have been moved, I have created redirects in the wormhole-mkdocs repo

@ilariae ilariae added the A0 - New Content Pull request contains new content pages label Sep 23, 2024
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only got a little way through and it started looking off to me. This guide should be about creating a contract that interacts with the token bridge directly, instead of JavaScript

build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
build/contract-integrations/token-bridge.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewed the Learn section content this time around. Huge improvement there! Nice job!

learn/messaging/token-nft-bridge.md Outdated Show resolved Hide resolved
learn/messaging/token-nft-bridge.md Outdated Show resolved Hide resolved
learn/messaging/token-nft-bridge.md Outdated Show resolved Hide resolved
learn/messaging/token-nft-bridge.md Outdated Show resolved Hide resolved

To facilitate cross-chain communication, the Token Bridge uses specialized payloads that carry the necessary information for token transfers and attestations. These payloads ensure that the correct tokens are minted or unlocked on the destination chain.

- `Transfer` - this payload initiates the transfer of tokens, either by minting wrapped tokens or releasing locked tokens
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do these payloads come from?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

learn/messaging/token-nft-bridge.md Outdated Show resolved Hide resolved
learn/messaging/token-nft-bridge.md Outdated Show resolved Hide resolved
learn/messaging/token-nft-bridge.md Outdated Show resolved Hide resolved
@eshaben
Copy link
Collaborator

eshaben commented Oct 24, 2024

@ilariae putting this into draft mode for now

@eshaben eshaben marked this pull request as draft October 24, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0 - New Content Pull request contains new content pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants