Fix infinite loop in address parsing #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artursapek
changed the title
artursapek
force-pushed
the
fix-addr-infinite-loop
branch
from
dbc0411 to
40931b5
Compare
|
Nice fix, ran into this before |
kev1n-peters
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Backpack dev ran into a bug where he was parsing a Sui address with
Ethereumas a chain by mistake, and it caused this function to calltoNativeinfinitely.This change maintains the fallback behavior where it tries to treat unparsed
UniversalAddressvalues as such, but without the potential to loop infinitely.