Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wormchain: add slashing params vaa #4194

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

wormchain: add slashing params vaa #4194

wants to merge 17 commits into from

Conversation

joelsmith-2019
Copy link
Collaborator

This PR adds a new Wormhole core governance action payload to Wormchain, allowing guardians to update the slashing parameters. I'm unsure where I should include documentation for how the payload is structured. If theres a specific README, please let me know and I'll add some documentation on it.

// Core Wormhole Module
Module [32]byte = "Core"

// Action index (6 for Slashing Params Update)
Action uint16 = 6

Chain uint16

// Signed Blocks Window (big-endian uint64)
SignedBlocksWindow uint64

// Min Signed Per Window (big-endian uint64)
MinSignedPerWindow uint64

// Downtime Jail Duration (big-endian uint64)
DowntimeJailDuration uint64

// Slash Fraction DoubleSign (big-endian uint64)
SlashFractionDoubleSign uint64

// Slash Fraction Downtime (big-endian uint64)
SlashFractionDowntime uint64

Ref to Cosmos SDK Slashing Params: Params

@joelsmith-2019 joelsmith-2019 self-assigned this Dec 16, 2024
@joelsmith-2019 joelsmith-2019 marked this pull request as ready for review December 17, 2024 19:12
bruce-riley
bruce-riley previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@bruce-riley bruce-riley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed the sdk stuff.

johnsaigle
johnsaigle previously approved these changes Jan 10, 2025
View reviewed changes
@joelsmith-2019 joelsmith-2019 force-pushed the joel/add-slashing-params-vaa branch from 1e8fc77 to 82e5a02 Compare January 10, 2025 19:50
@joelsmith-2019 joelsmith-2019 force-pushed the joel/add-slashing-params-vaa branch from 82e5a02 to 96966ea Compare January 10, 2025 19:52
@joelsmith-2019
Copy link
Collaborator Author

@bruce-riley would you be able to re-review this after the few minor changes I added last week?

bruce-riley
bruce-riley previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@bruce-riley bruce-riley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed the sdk/vaa changes. I am not an owner of anything else.

@joelsmith-2019 joelsmith-2019 force-pushed the joel/add-slashing-params-vaa branch from 96966ea to 635379c Compare January 14, 2025 17:06
kakucodes
kakucodes requested changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@kakucodes kakucodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple small nits here- nothing big.

wormchain/x/wormhole/client/cli/genesis.go Outdated Show resolved Hide resolved
wormchain/x/wormhole/keeper/msg_server_execute_governance_vaa_test.go Outdated Show resolved Hide resolved
kakucodes
kakucodes previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@kakucodes kakucodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code and left a couple small nits but overall everything lgtm!

johnsaigle
johnsaigle previously approved these changes Jan 15, 2025
View reviewed changes
@kakucodes kakucodes requested a review from bruce-riley January 27, 2025 21:37
@nik-suri nik-suri requested a review from johnsaigle January 27, 2025 21:37
kakucodes
kakucodes previously approved these changes Jan 27, 2025
View reviewed changes
bruce-riley
bruce-riley approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@bruce-riley bruce-riley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I only reviewed the sdk stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-gray evan-gray Awaiting requested review from evan-gray evan-gray is a code owner

@panoel panoel Awaiting requested review from panoel panoel is a code owner

@SEJeff SEJeff Awaiting requested review from SEJeff SEJeff is a code owner

@nik-suri nik-suri Awaiting requested review from nik-suri nik-suri is a code owner

@mdulin2 mdulin2 Awaiting requested review from mdulin2 mdulin2 is a code owner

@bruce-riley bruce-riley Awaiting requested review from bruce-riley bruce-riley is a code owner

@johnsaigle johnsaigle Awaiting requested review from johnsaigle johnsaigle is a code owner

@kakucodes kakucodes Awaiting requested review from kakucodes

At least 2 approving reviews are required to merge this pull request.

Assignees

@joelsmith-2019 joelsmith-2019

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joelsmith-2019 @johnsaigle @bruce-riley @kakucodes