Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node/Solana: Reobservation by transaction ID #4223

Conversation

bruce-riley
Copy link
Contributor

@bruce-riley bruce-riley commented Jan 16, 2025

This PR adds the ability to do Solana reobservations using the transaction ID (signature). This is in addition to the current way using the account ID.

Tested using the following commands against mainnet.

wormhole$ build/bin/guardiand admin send-observation-request 1 6ybzWxyEvz4g4vU7P8DTjUFSAC3dPPGgZM9WfGS7rv57 --socket /tmp/admin.sock
wormhole$ build/bin/guardiand admin send-observation-request 1 4yMxR5uZCURTKfa4SW92wScpN4ufEMbaKdAtn8bjtngXHjry4dAFuihDVnRpQDX5YpwugxqcDXt7EYaNEkiZkpps --socket /tmp/admin.sock

@bruce-riley bruce-riley marked this pull request as ready for review January 16, 2025 18:03
node/pkg/watchers/solana/client.go Show resolved Hide resolved
node/pkg/watchers/solana/client.go Outdated Show resolved Hide resolved
node/pkg/watchers/solana/client.go Outdated Show resolved Hide resolved
@bruce-riley bruce-riley requested a review from evan-gray January 16, 2025 20:12
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would recommend getting this reviewed and merged first, then rebasing #4219

@bruce-riley bruce-riley merged commit 8cf8650 into wormhole-foundation:main Jan 16, 2025
28 checks passed
@bruce-riley bruce-riley deleted the node/solana_reobservation_by_txid branch January 16, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants