ci: Bump golang linter version #4224
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsaigle
reviewed
Jan 20, 2025
node/cmd/guardiand/adminclient.go
Outdated
| @@ -312,6 +314,11 @@ func runFindMissingMessages(cmd *cobra.Command, args []string) { | |||
| } | |||
| defer conn.Close() | |||
|
|
|||
| // Although chains ids are constrained to be 16 bit, we only constrain to 32 bit here given the protobuf usage later | |||
| if chainID > math.MaxUint32 { | |||
There was a problem hiding this comment.
IMO we can constrain this and similar uses to math.MaxUint16 instead. Opening up the range only makes bugs more likely, even if protobuf encodes them as uint32
| @@ -343,6 +350,10 @@ func runDumpVAAByMessageID(cmd *cobra.Command, args []string) { | |||
| if err != nil { | |||
| log.Fatalf("invalid chain ID: %v", err) | |||
| } | |||
| // We only constrain this to int32 now, not uint16, given the ChainID protobuf definition | |||
| if chainID > math.MaxInt32 { | |||
There was a problem hiding this comment.
Same here, my preference would be Uint16
node/hack/repair_eth/repair_eth.go
Outdated
| from = strconv.Itoa(int(currentHeight - step)) | ||
| to = "latest" | ||
| lastHeight = currentHeight | ||
| } else { | ||
| if lastHeight-step > math.MaxInt { |
There was a problem hiding this comment.
Does it make sense to also check negative values here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP