-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Fixes issues for content replacement for the site and media URLs #2014
Merged
+395
−62
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2be8bfe
Fix for #1986. Fixes various issues with content replacement callback…
colinmurphy 70a67ef
Fixed issues with PHPCS
colinmurphy 03a33a9
Updated PR to replace srcset URL for different HTTP Protocols
colinmurphy be14c9a
Added changeset
colinmurphy c6ed6d5
Refactoring based off @whoami-pwd feedback. Reduced some of the nes…
colinmurphy f48551b
Merge branch 'canary' into bug-fix-url-rewrite-issues
colinmurphy 400e7fc
Fixes for linting
colinmurphy acabb9e
Update plugins/faustwp/includes/replacement/callbacks.php
colinmurphy 8e9a232
Added fixes as per code review from @whoami-pwd
colinmurphy 9770673
Refactoring some of the image srcset replacement.
colinmurphy 71b1d68
Small fix for PHPCS for a missing fullstop
colinmurphy 58d19df
Refactoring some of the media urls with @whoami-pwd
colinmurphy e37f7b0
Fixes
colinmurphy 11f1db2
Small refactor of parameters with @whoami-pwd
colinmurphy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Refactoring some of the image srcset replacement.
commit 97706731fa55fc98f1a4d44e6f5bc0b901899991
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please typecast here to make sure it is string with some default value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not allowed by our phpcs settings 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I was wrong here.