Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect when SimDevice.create* is creating a duplicate and report an error #7727

Open
spacey-sooty opened this issue Jan 24, 2025 · 1 comment

Comments

@spacey-sooty
Copy link
Contributor

Right now if I create two identical SimBooleans from the same SimDevice I just get a null pointer exception, a message saying the names conflict would be nice.

@KangarooKoala
Copy link
Contributor

Someone more knowledgeable about the HAL than me would need to check if this would violate an assumption about the return value of HAL_CreateSimDevice(), but I think we could change the return value in SimDeviceData::CreateDevice to a unique negative error code which SimDevice.create() could detect to throw an exception instead of returning null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants